Change default S3 repository chunk_size #112708
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhl-b
added
>bug
:Distributed Coordination/Snapshot/Restore
|
Pinging @elastic/es-distributed (Team:Distributed) |
mhl-b
changed the title
DaveCTurner
requested changes
Sep 10, 2024
There was a problem hiding this comment.
I'd rather we approached this differently: let's introduce a new repository setting for the maximum number of parts, defaulting to 10k, and then work out how to split each file up into blobs and parts dynamically based on the combination of max-parts, chunk_size and buffer_size. That way if users have set one or more of these values then we'll continue to respect their setting.
|
Closing in favour of #113989, using a new repository setting for the maximum number of parts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current default S3 repository settings are in conflict with S3 limit for multi-part upload. We split large files into 5TiB chunks with 100Mb part size. That means we need to send up to 50k parts, where S3 limit is 10k. https://docs.aws.amazon.com/AmazonS3/latest/userguide/qfacts.html
This PR changes default
chunk_sizetodefault_part_size * max_parts_number(10k), which should be in range of[50Gb, 5Tib]